Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Change output link for button + add space between number and 'download' #1771

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

Skraye
Copy link
Member

@Skraye Skraye commented Jul 18, 2023

close #1769

@Skraye Skraye self-assigned this Jul 18, 2023
@Skraye Skraye force-pushed the feat/downloadlink-as-button branch from c6dcd61 to 2cee386 Compare July 21, 2023 07:50
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just delete the download method which is no longer used

Comment on lines 35 to 37
download(value) {
const url = this.itemUrl(value);
window.open(url, "_blank");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore

@Skraye Skraye merged commit 932783c into develop Jul 24, 2023
@Skraye Skraye deleted the feat/downloadlink-as-button branch July 24, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Download link in output with proper button
2 participants